[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 08/36] include/qemu/int128: Use Int128 structure for TCI
From: |
Alex Bennée |
Subject: |
Re: [PATCH v5 08/36] include/qemu/int128: Use Int128 structure for TCI |
Date: |
Fri, 27 Jan 2023 13:51:34 +0000 |
User-agent: |
mu4e 1.9.16; emacs 29.0.60 |
Richard Henderson <richard.henderson@linaro.org> writes:
> We are about to allow passing Int128 to/from tcg helper functions,
> but libffi doesn't support __int128_t, so use the structure.
>
> In order for atomic128.h to continue working, we must provide
> a mechanism to frob between real __int128_t and the structure.
> Provide a new union, Int128Alias, for this. We cannot modify
> Int128 itself, as any changed alignment would also break libffi.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- Re: [PATCH v5 05/36] tcg: Add TCG_CALL_{RET,ARG}_BY_REF, (continued)
- [PATCH v5 02/36] tcg: Handle dh_typecode_i128 with TCG_CALL_{RET, ARG}_NORMAL, Richard Henderson, 2023/01/25
- [PATCH v5 01/36] tcg: Define TCG_TYPE_I128 and related helper macros, Richard Henderson, 2023/01/25
- [PATCH v5 04/36] tcg: Introduce tcg_out_addi_ptr, Richard Henderson, 2023/01/25
- [PATCH v5 07/36] tcg: Add TCG_CALL_RET_BY_VEC, Richard Henderson, 2023/01/25
- [PATCH v5 06/36] tcg: Introduce tcg_target_call_oarg_reg, Richard Henderson, 2023/01/25
- [PATCH v5 09/36] tcg/i386: Add TCG_TARGET_CALL_{RET,ARG}_I128, Richard Henderson, 2023/01/25
- [PATCH v5 08/36] include/qemu/int128: Use Int128 structure for TCI, Richard Henderson, 2023/01/25
- Re: [PATCH v5 08/36] include/qemu/int128: Use Int128 structure for TCI,
Alex Bennée <=
- [PATCH v5 10/36] tcg/tci: Fix big-endian return register ordering, Richard Henderson, 2023/01/25
- [PATCH v5 11/36] tcg/tci: Add TCG_TARGET_CALL_{RET,ARG}_I128, Richard Henderson, 2023/01/25
- [PATCH v5 12/36] tcg: Add TCG_TARGET_CALL_{RET,ARG}_I128, Richard Henderson, 2023/01/25
- [PATCH v5 14/36] tcg: Add basic data movement for TCGv_i128, Richard Henderson, 2023/01/25
- [PATCH v5 13/36] tcg: Add temp allocation for TCGv_i128, Richard Henderson, 2023/01/25