[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: TeX-documentation-texdoc
From: |
Ikumi Keita |
Subject: |
Re: TeX-documentation-texdoc |
Date: |
Fri, 27 Jan 2023 19:18:26 +0900 |
Hi Arash,
>>>>> Arash Esbati <arash@gnu.org> writes:
> Thanks for working on this. Reg.
> 0001-Make-TeX-documentation-texdoc-work-for-okular, I have some minor
> comments:
Thanks.
> I think we can shorten this by calling `thing-at-point' with the
> optional second argument NO-PROPERTIES
> (thing-at-point THING &optional NO-PROPERTIES)
> When the optional argument NO-PROPERTIES is non-nil,
> strip text properties from the return value.
> => (let ((pkg (thing-at-point 'symbol t))
Indeed. I wasn't aware of the optional argument.
> Is this `save-excursion' really necessary? Or am I missing something?
Thanks, I just copied the previous code without looking at it well.
> + (while (re-search-forward
> + ;; XXX: XEmacs doesn't support character classes in
> + ;; regexps, like "[:alnum:]".
> I think we can delete this comment.
OK.
> I think we should borrow some code from the compat-package[1] and
> introduce our `TeX-format-prompt' and once we're at Emacs 28, we just
> alias it to `format-prompt' or use `format-prompt' directly. Suppose we
> have this in tex.el:
> Then we could write:
> (setq pkg (TeX-read-string (TeX-format-prompt
> "View documentation for" pkg)
> nil nil pkg))
> Adjusting the other 30 occurrences in the repo should be easy. WDYT?
That's a good idea. Can I leave that work to you?
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
0001-Fix-TeX-documentation-texdoc-for-okular.patch.gz
Description: revised patch
- Re: TeX-documentation-texdoc, (continued)
- Re: TeX-documentation-texdoc, Pieter van Oostrum, 2023/01/21
- Re: TeX-documentation-texdoc, Greg Bognar, 2023/01/21
- Re: TeX-documentation-texdoc, Ikumi Keita, 2023/01/22
- Re: TeX-documentation-texdoc, Greg Bognar, 2023/01/22
- Re: TeX-documentation-texdoc, Ikumi Keita, 2023/01/23
- Re: TeX-documentation-texdoc, Greg Bognar, 2023/01/23
- Re: TeX-documentation-texdoc, Ikumi Keita, 2023/01/24
- Re: TeX-documentation-texdoc, Greg Bognar, 2023/01/24
- Re: TeX-documentation-texdoc, Ikumi Keita, 2023/01/26
- Re: TeX-documentation-texdoc, Arash Esbati, 2023/01/26
- Re: TeX-documentation-texdoc,
Ikumi Keita <=
- Re: TeX-documentation-texdoc, Arash Esbati, 2023/01/27
- Re: TeX-documentation-texdoc, Ikumi Keita, 2023/01/28
- Re: TeX-documentation-texdoc, Arash Esbati, 2023/01/24
- Re: TeX-documentation-texdoc, Ikumi Keita, 2023/01/25