Re: Issue 4560: group #include directives at top of file (issue 254670043 by address@hidden)

[David Kastrup]

address@hidden writes:

> https://codereview.appspot.com/254670043/diff/60001/flower/include/std-vector.hh
> File flower/include/std-vector.hh (right):
>
> https://codereview.appspot.com/254670043/diff/60001/flower/include/std-vector.hh#newcode70
> flower/include/std-vector.hh:70: #if HAVE_STL_DATA_METHOD
> As it stands, this patch would appear quite broken to me as it fails to
> work when the config variable HAVE_STL_DATA_METHOD is 0: in that case,
> std-vector.hh defines its own vector template class that is _not_
> accessible via std::vector.
>
> Until this is sorted out, I strongly suggest that we revert this patch.
>
> https://codereview.appspot.com/254670043/

Since this patch touches a lot of code, I'd recommend to all with a
Patch-push tag who find that they'd need to fix merge conflicts when
rebasing to current master to just do

git rebase --abort

and rather wait whether we'll indeed revert this patch for now.  It
would be a nuisance if they fixed the merge conflicts and pushed with
the result that the revert of issue4550 takes more work and is harder to
disentangle.

Dan, any input on the HAVE_STL_DATA_METHOD issue?  Reverting here would
also conveniently postpone our problems with what appears to be
incomplete coverage of isinf and other functions.

-- 
David Kastrup