[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 4560: group #include directives at top of file (issue 25467004
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: Issue 4560: group #include directives at top of file (issue 254670043 by address@hidden) |
|
Date: |
Sun, 23 Aug 2015 18:48:00 +0000 |
On 2015/08/23 16:31:46, dak wrote:
> As it stands, this patch would appear quite broken to me as it fails
to
> work when the config variable HAVE_STL_DATA_METHOD is 0: in that
case,
> std-vector.hh defines its own vector template class that is _not_
> accessible via std::vector.
Drat. Do we need this huge kludge in this day and age? Any idea which
platform this is necessary for?
> Until this is sorted out, I strongly suggest that we revert this
patch.
I agree.
https://codereview.appspot.com/254670043/