[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] overquoting in implementation of %code and %defines

From: Joel E. Denny
Subject: Re: [PATCH] overquoting in implementation of %code and %defines
Date: Mon, 15 Jan 2007 03:58:33 -0500 (EST)

On Mon, 15 Jan 2007, Paolo Bonzini wrote:

> > 1. b4_percent_define_foo is the value of foo.  However, skeleton authors
> > shouldn't need to touch this.
> I'm instead proposing the special macro b4_percent_define(foo) -- also in
> Bison's output, and also for b4_percent_code(bar) -- but apart from this
> default yes, we agree.  This kind of "foo(bar)" macro name is the same that I
> used in my change to how you implemented the check for unused %define/%code
> definitions.

The M4 documentation mentions this sort of privacy as one of the purposes 
of m4_indir, so that's a clue that this is on track.

> > We may eventually want a b4_is_defined_percent_define([[foo]]).
> I'd say b4_has_percent_define/b4_has_percent_code instead.

That's looks good.

As I mentioned, I've already started revising the patch.  However, I think 
I should update it for some of this before committing.  It'll have to be 
tomorrow though.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]