[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] overquoting in implementation of %code and %defines

From: Joel E. Denny
Subject: Re: [PATCH] overquoting in implementation of %code and %defines
Date: Mon, 15 Jan 2007 03:21:11 -0500 (EST)

On Mon, 15 Jan 2007, Paolo Bonzini wrote:

> > Please don't.  m4_define_default is preferable in my opinion.  I really see
> > no reason to extend b4_get_percent_define, but I will just to settle this.
> Note that the reason I don't like the current implementation is because I'm
> against "magic" macro names.

Ok, I see that point.  In my own words, accessing b4_percent_define_foo 
directly seems to break data encapsulation.

> So another way to break the tie and not add the second parameter would be to
> change the default macro name to "b4_get_percent_define(NAME)" and have a
> "b4_define_default(NAME, FOO)" macro that defines this special-named macro.

Ok, how about this?

  b4_default_percent_define([[foo]], [[default value]])

reply via email to

[Prev in Thread] Current Thread [Next in Thread]