[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35062: [PATCH v3 1/3] Remove redundant comparison

From: Eli Zaretskii
Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison
Date: Mon, 15 Apr 2019 20:16:32 +0300

> Date: Mon, 15 Apr 2019 20:03:05 +0300
> From: Konstantin Kharlamov <address@hidden>
> Cc: address@hidden, address@hidden
> > No, the log message was not the problem.  Look at the code changes,
> > they were the ones I modified.
> The line that I changed is exactly the same. What you did is cleaning 
> up the function even further, however that didn't touch my 
> modifications. Your modification is not strictly relevant to my patch.

That's your perspective, but not mine.  My perspective is that you
changed one line, whereas I changed 3, and by that also changed the
overall logic of the tests.

> Okay, let's compare:
> 1. Doing extra commit:  "git commit"
> 2. Changing last commit "git commit --amend"
> You did 2, do you see how 1 has less symbols?

No I didn't do 2.  I just edited the sources and did 1.  I never
applied your patch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]