Re: How about simply include files?

[Sven Luther]

On Wed, Jan 21, 2004 at 08:25:24PM -0500, Mathieu Bruneau wrote:
> Hi again,
>    There is probably a good reason at the base of it but i'm wondering 
> what is/are the exact reason(s). Why are doing it like that.
> 
> Why are you copying part of system headers files (like in 
> libparted/linux.c) ? This is what make my errors (BLKGETSIZE64 is not 
> defined as sizeof(uint_64))

look at the debian parted packages, they have been neetly dpatchified,
and there is a patch (in debian/patches) which fix this issue. BTW, part
of the problem is a bug in the 2.6.x kernel include header, and the
kernel guys don't particularly care about it.

Also, notice that including kernel header files in userland application
seems to be a big nono, and only source of problems. We are supposed to
copy all the needed includes in the userland app, in order to be
protected from gratuitous kernel header changes like those which my
break everything (dixit the kernel guys).

Andrew, we really need a CVS or whatever repository, so all people
making modifications can share the stuff back. Could you make an update
of your effort in this matter. If it fails, i have in the past proposed
to open an alioth project, and have the parted source in a subversion or
arch repository there.

Friendly,

Sven Luther