[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Any exceptions for the 15-line rule?

From: Dmitry Gutov
Subject: Re: Any exceptions for the 15-line rule?
Date: Thu, 02 May 2013 00:37:04 +0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5

On 01.05.2013 22:06, Glenn Morris wrote:
Dmitry Gutov wrote:

Thank you. I don't think I've seen a good definition of "tiny change"
anywhere, and there's no s/foo/bar in either of these patches, but if
you suggest to use my own judgment, that's fine by me.

s/foo/bar was just an example.

You need to look at the change and ask, "conceptually, how big is this"?
Deleting says 15 lines of common code from two places and turning it
into a separate function that those two places call only "counts" as a
few lines IMO (the function definition part, the function body is the
same code as before, just moved around).

I see, that's good.
The two function invocations should probably also count, as +1 or +2.

What about the second patch?


Should it be counted as just +3 (for the added docstring), or does the tweaked list of identifiers also contribute? I'm thinking no, because the change only removes elements from the list.

What if the diff was adding new elements (like the reverse of this diff would do)? Would I be able to discount those lines then, on the basis that this is just copying information from the specification?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]