[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Any exceptions for the 15-line rule?

From: Dmitry Gutov
Subject: Re: Any exceptions for the 15-line rule?
Date: Sat, 04 May 2013 09:27:05 +0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5

On 27.04.2013 8:41, Stefan Monnier wrote:
The latter is licensed under GPLv3+, but I'm pretty sure the author
(brianjcj AT gmail, not sure what's his full name) has not signed the
CA. And I'm not wild about the idea of waiting several months to add the
feature (that is, if the author even agrees to sign the CA).

The change includes

    -    (with-temp-buffer
    +        (buf (get-buffer-create "*clang-output*"))
    +    (with-current-buffer buf (erase-buffer))
    +    (with-current-buffer buf

Which seems like it's making the code worse rather than better.
If you undo this undesirable part of the patch, it'll be closer to
the acceptable limit.

So, I've merged the patch into Git repo with some modifications, but looks like the above change is perfectly justified: the new code uses `call-process-region', which takes the region from the current buffer, so using it with `with-temp-buffer' doesn't seem possible.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]