Re: Towards a cleaner build: bindat

[Lars Ingebrigtsen]

This one's funny:

In toplevel form:
mail/feedmail.el:2151:1:Warning: Unused lexical argument `helper'


(defun feedmail-queue-send-edit-prompt-inner (default prompt reprompt helper
                                              standard-alist user-alist)

[...]

          (if (= user-sez help-char)
              ;; FIXME: This seems to want to refer to the `helper' argument,
              ;; but it's quoted so the `helper' arg ends up unused!
              (setq answer '(^ . helper))

[...]

      (cdr answer))))


The only call to this function is

  (feedmail-queue-send-edit-prompt-inner
   feedmail-ask-before-queue-default
   feedmail-ask-before-queue-prompt
   feedmail-ask-before-queue-reprompt
   'feedmail-message-action-help
   feedmail-prompt-before-queue-standard-alist
   feedmail-prompt-before-queue-user-alist
   ))

so `helper' is always `feedmail-message-action-help', but as the comment
says, it's never used, but instead the symbol `helper' is returned from
the function, and it's then funcalled:

  (if (not feedmail-enable-queue) (feedmail-send-it-immediately-wrapper)
    ;; else, queuing is enabled, should we ask about it or just do it?
    (if feedmail-ask-before-queue
        (funcall (feedmail-queue-send-edit-prompt))
      (feedmail-dump-message-to-queue feedmail-queue-directory 'after-queue)))

So this seems like a genuine bug.

Are there any feedmail users here?  Is so, could you
(setq feedmail-enable-queue t) and see whether you get an error when
sending mail?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no