[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Towards a cleaner build: feedmail
From: |
Eli Zaretskii |
Subject: |
Re: Towards a cleaner build: feedmail |
Date: |
Sat, 15 Jun 2019 18:30:54 +0300 |
> From: Lars Ingebrigtsen <address@hidden>
> Cc: address@hidden
> Date: Sat, 15 Jun 2019 17:28:13 +0200
>
> I think the fix is pretty trivial:
>
> diff --git a/lisp/mail/feedmail.el b/lisp/mail/feedmail.el
> index 943bdd8851..6f50c3e4ed 100644
> --- a/lisp/mail/feedmail.el
> +++ b/lisp/mail/feedmail.el
> @@ -2170,7 +2170,7 @@ feedmail-queue-send-edit-prompt-inner
> (if (= user-sez help-char)
> ;; FIXME: This seems to want to refer to the `helper' argument,
> ;; but it's quoted so the `helper' arg ends up unused!
> - (setq answer '(^ . helper))
> + (setq answer (cons '^ helper))
> (if (or (eq user-sez ?\C-m) (eq user-sez ?\C-j) (eq user-sez ?y))
> (setq user-sez d-char))
> ;; these char-to-int things are because of some
>
> but it would be nice to have someone confirm that this analysis is right
> before doing anything.
I don't think you'll find someone to confirm: feedmail is probably
going to be moved to obsolete/. So I suggest to push that change.
- Re: Towards a cleaner build: eieio, (continued)
- Re: Towards a cleaner build: eieio, Stefan Monnier, 2019/06/14
- Re: Towards a cleaner build: eieio, Lars Ingebrigtsen, 2019/06/14
- Re: Towards a cleaner build: eieio, Stefan Monnier, 2019/06/14
- Re: Towards a cleaner build: eieio, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: bindat, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: bindat, Eli Zaretskii, 2019/06/15
- Re: Towards a cleaner build: bindat, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: bindat, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: bindat, Eli Zaretskii, 2019/06/15
- Re: Towards a cleaner build: feedmail, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: feedmail,
Eli Zaretskii <=
- Re: Towards a cleaner build: feedmail, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: tags, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: srecode/insert, Lars Ingebrigtsen, 2019/06/15
- Re: Towards a cleaner build: srecode/insert, Eric Ludlam, 2019/06/16
- Re: Towards a cleaner build: srecode/insert, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: tags, Dmitry Gutov, 2019/06/15
- Re: Towards a cleaner build: tags, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: select.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/16