[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: BIKESHED: completion faces

From: Stefan Monnier
Subject: Re: BIKESHED: completion faces
Date: Tue, 05 Nov 2019 10:44:29 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> I've tried to implement my idea, but somehow the added highlighting gets
> eaten before the buffer is displayed. But the attached patch should 
> illustrate it anyway.

Regardless of how we implement this, the question remains: do we want to
highlight the common-part of the prefix/basic completion differently
from the other cases?


PS: I think the approach used in your patch will lead to undesirable
behavior when some matches (but not all) have all chars before
first-diff highlighted with common-part.  E.g.

    src/emacs -Q --eval '(setq completion-styles (quote (partial-completion)))'
    M-x re-b ?

where `re-builder` would be highlighted with a "trivial common part"
whereas `rename-buffer` would be highlighted differently.

You might consider it as a feature, of course.  But if not, then we'd
have to first look at all the completions to make sure they all have
a "trivial common part".

reply via email to

[Prev in Thread] Current Thread [Next in Thread]