Re: __attribute__ ((cleanup)) and emacs-module.c

[Paul Eggert]

On 2023-03-10 17:37, Po Lu wrote:

> +#define MODULE_INTERNAL_CLEANUP                        \
> +  module_reset_handlerlist (&internal_cleanup)

No need for the "&" here. Omit it, and change the type of 
module_reset_handlerlist to take 'struct handler *' instead of 'struct 
handler **'.

Also, please make this macro a parameterless function-style macro called 
via 'MODULE_INTERNAL_CLEANUP ()' as it acts like a function.

Also, please define a macro MODULE_FUNCTION_END something like this:

  #define MODULE_FUNCTION_END(retval) \
     (MODULE_INTERNAL_CLEANUP (), retval)

and use 'return MODULE_FUNCTION_END (<simple-expression>);' when the 
cleanup is immediately followed by a return of a value of a simple 
expression. For complex expressions that can throw exceptions, you can 
use something like:

    <type> r = <complex-expression>;
    return MODULE_FUNCTION_END (r);