Re: Mistakes in commit log messages

[Jim Porter]

On 4/15/2023 10:43 PM, Eli Zaretskii wrote:
> And that's _a_lot_, no matter how you count them.  Which should give
> people here some idea why I raised this issue in the first place: I
> needed to fix all those cases by hand while working on the pretest
> tarball.

Yeah, it's quite a bit more than I expected.

Overall, I think the hooks are working pretty well now, and all the 
false positives should (hopefully) be resolved. Assuming there are no 
further issues, I'll merge them in a few days. Worst-case scenario, 
committers would just need to pass "--no-verify" to skip the hooks (or 
uninstall them temporarily), and then file a bug about any problems they 
find with the hooks.

Another, more-general thing we could consider is to add a job on EMBA 
that tries to run through the automatable steps of making pretest 
tarballs, just to see if they complete without errors. Then we could set 
that to run, say, once a week, so we could identify problems earlier and 
fix them (e.g. by adding new Git hooks, or just sending a message to 
emacs-devel about it).