Re: [Nano-devel] [PATCH] Some improvements

[Liu Hao]

On 2017/12/8 4:22, Benno Schulenberg wrote:
> 
> Op 07-12-17 om 10:48 schreef Liu Hao:
>> These are patches discussed earlier today, now reshuffled and signed
>> off. Please review
> 
> About all patches: your subject lines are far too long.  Look at the
> git repo.  The first line of a commit message is at most 74 characters
> long.  If you need more text, use a second, separate paragraph.
> 
Done.

> About the second patch: why does coloring of preprocessor directives
> now require two color statements?  And statements that are nearly
> identical at that.  Why can't it be done with one of them?
> 
Amended.

> Sixth patch: brightred on yellow is in the same class as grey on yellow.
> It's just a change, not an improvement.  I will accept brightwhite, but
> not anything else.
> 
I tested brightwhite on my terminal and it looks better than grey on
yellow, so I think this is a solution. Amended.

> Seventh patch: there is no need for a boolean 'can_unindent' to achieve
> the desired behavior.  And there is no need for feedback when there is
> nothing to unindent -- there is no feedback either when it's impossible
> to go further up or down or home.  See attached patch for the minimum
> amount of changes required to get the new behavior.  (In a second patch
> you could rewrite the length_of_white() routine, but then it has to
> become shorter than what you have now.)
> 
I copied the modification for `do_unindent()`. But in the case of
`length_of_white()` I found the old code less maintainable so it got
rewritten.


> Benno
> 
> 
> _______________________________________________
> Nano-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/nano-devel
> 


-- 
Best regards,
LH_Mouse

0001-syntax-add-some-more-rules-for-C-and-C.patch
Description: Text document

0002-syntax-adjust-highlighting-of-preprocessor-directive.patch
Description: Text document

0003-syntax-remove-highlighting-of-angle-brackets.patch
Description: Text document

0005-syntax-remove-colorization-of-labels-in-C.patch
Description: Text document

0006-syntax-mark-reminders-as-brightwhite-on-yellow.patch
Description: Text document

0007-tweaks-alter-undenting-behavior.patch
Description: Text document