Re: [Nano-devel] [PATCH] Some improvements

[Liu Hao]

On 2017/12/10 1:04, Benno Schulenberg wrote:
> 
>>> About the second patch: why does coloring of preprocessor directives
>>> now require two color statements?  And statements that are nearly
>>> identical at that.  Why can't it be done with one of them?
>>
>> Amended.
> 
> The new version does not color a lonely #else or #endif.
Oops it was an oversight. ... well, how to work around it without
look-ahead assertions? :/

> 
> Also, it is a drain on resources: opening a large C file now takes twice
> as long. The precalculation of the color info takes roughly five times as
> long as for the disabled coloring of multiline strings.  It was disabled
> to avoid irritating slowdowns.  So, I don't think we can do the multiline
> regexes for preprocessor directives.
> 
I was aware of it anyway, but I think 'large C files' are relatively rare.

>> I tested brightwhite on my terminal and it looks better than grey on
>> yellow, so I think this is a solution. Amended.
> 
> Thanks.  Pushed, 5144162a.
> 
>> I copied the modification for `do_unindent()`. But in the case of
>> `length_of_white()` I found the old code less maintainable so it got
>> rewritten.
> 
> :|  You didn't do as asked, so I have pushed my own version.
> 
I have no objection to it as long as everything works expectantly.

> About the other patches... I can't judge whether they are relevant.
> Someone else please chime in.
> 
> Benno
> 
> _______________________________________________
> Nano-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/nano-devel


-- 
Best regards,
LH_Mouse