Re: [Pan-devel] some patches

[Christophe Lambin]

On Wed, 2003-01-08 at 06:54, Haran Shivanan wrote:
> Module 'Christophe Lambin' core dumped on 7 Jan 2003 with the following output
> 
> > 4. gtk_text_tag_copy_values() relies on the current definition of the
> > GtkText structure. I feel it would be better to have
> > gtk_text_tag_table_install() remove the old tag and install the new one
> > instead. This would also fix the memory leak in 3.
> [...]
> The approach I finally took was lifted from the gtk-devel mailing list.
> Copying the tag members explicitly is bound to break if there are changes
> in the tag so I don't like it either, but so far, I'm just going with what
> works. I saw some gtk_text_tag documentation but it didn't seem to offer
> any different solution. Any ideas?

Not really. You seem to be one step ahead of me on this one, so that
approach seems to be a necessary fallback.


> [ Signatures ]
> Charles suggested supporting it provided we don't fall into the trap where
> the "\n--\n" token did not represent a delimited signature.
> That is, make sure there are no "\n-- \n" tokens following it in the
> message.
> 
> How would that be?

I've been overruled by the boss, so that would be fine. :)

Regards,
Christophe