[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/3] move loading of modules out of the AddModule call back
From: |
Andrei . Kholodnyi |
Subject: |
[PATCH 2/3] move loading of modules out of the AddModule call back |
Date: |
Fri, 19 Nov 2010 13:43:49 +0000 |
> Hi Andrei and Trevor,
> As it stands right now, the task of loading modules is intertwined with
> the task of parsing the configuration file. Parsing has side-effects.
> I haven't looked too closely at this patch, but if I understand it
> correctly, the parser no longer loads modules. To me, this seems like a
> clean separation of the two tasks.
> Thoughts?
For me the proper approach would be:
- configuration.c is responsible for nothing, but reading AddModules
strings from conf and putting it in array of strings.
- speechd after reading conf, retrieves this array of strings <module1,
module2..>, parameter ModuleAutodetection
and implements whatever discovery/loading algorithm it wants.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101119/48f0a2ca/attachment.htm>
- rfc module autodetection patch set, Trevor Saunders, 2010/11/18
- [PATCH 1/3] output_modules should be declared in a c file not a header, Trevor Saunders, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Trevor Saunders, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/19
- [PATCH 2/3] move loading of modules out of the AddModule call back,
Andrei . Kholodnyi <=
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/26
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/27
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/28
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/28
[PATCH 3/3] add an initial module detection algorithm, Trevor Saunders, 2010/11/18
rfc module autodetection patch set, Christopher Brannon, 2010/11/18