[PATCH 2/3] move loading of modules out of the AddModule call back

[Christopher Brannon]

Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:
>
> I have resubmitted Trevor's patches with my proposed modifications for review.

Hi Andrei,
The first patch does not account for rereading of the configuration
file.  Start speech-dispatcher, play around a little bit, and send it a
SIGHUP.  It will (probably) segfault.
We actually need to do the loading at the very end of
speechd_load_configuration, since this function can be called by
speechd_init or as the SIGHUP signal handler.

I refactored this patch once again, and I'll send the new one once I'm
happy with it.  The list is kept private in module.c, and it can only be
manipulated by two functions: module_add_load_request and
module_load_requested_modules.
I'll also have to rework the second patch, to account
for my change, unless you want to resubmit.  I haven't looked at patch 2
yet.

Since this is a significant change by me, I'm not sure whether
either of us can review it.  Will it be the responsibility of one of the
other four reviewers?

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101128/ada7f2b4/attachment.pgp>