speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

rfc module autodetection patch set


From: Christopher Brannon
Subject: rfc module autodetection patch set
Date: Thu, 18 Nov 2010 12:18:10 +0000

Trevor Saunders <trev.saunders at gmail.com> writes:
> There are some things that should be thought about some here.
> * currently modules file name starts with sd_xxxx do we have a good
>  reason for this

I'm guessing that it is an historical artifact.

> *do we want to look at permissions at all, I don't think there is any
> security issue with not doing so, but does anyone else have thoughts on
> this?

Yes.  Make sure that it is owned by root and executable by
the owner of the server process.  The module directory shouldn't be
writable by users other than root, so this is probably just a little
extra defensiveness on my part.

> *we still deal with all the module loading in
> speechd_load_configuration() is this where we want it to happen?

Last time I looked, this could use a refactoring.

> *it would be nice for autodetection to be able to work with the generic
> module to some degree, based on the way the current support works

I don't know how we can make this work.  Right now, all of the
generic configs are installed on the user's system.  There's no way of
knowing which of them will actually work for the user.

> *I keept the Addmodule directive so people could deal with configuring
> modules not in the MODULEBINDIR, and other nonstandard things.

Good!  I also propose an ExcludeModule directive, which prevents a
module from being loaded by autodetection.
E.G.,
ExcludeModule "sd_ibmtts"

It's nice to see the ball rolling on this feature!

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101118/99eb9e80/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]