[bongo-devel] Re: VLC and audio CD's

[Daniel Jensen]

Daniel Brockman <address@hidden> writes:

> I added case to all the descriptions (e.g., `URI'),
> and used `completion-ignore-case' for convenience.

Good. I didn't read that far in the documentation.

>>   "An alist of insertion commands for `bongo-insertion-dispatcher'.")
>
> You should usually elide articles from the start of docstrings.

It is very common in Emacs sources (hundreds of cases). Is this
mentioned in a style guide somewhere?

>>   (let ((command (cdr (assoc (completing-read "Insert: "
>>                                               bongo-insertion-commands nil t)
>>                              bongo-insertion-commands))))
>>     (and command (call-interactively command))))
>
> I removed the `(and command ...)' check, because I figured
> it should never fail so it's clearer to just let it blow up.
> (Let me know if you think this is a mistake.)

It will fail if the user enters an empty string. We shouldn't use a
default value in that case (hence the check), though a message might
be OK.