Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot

[Felician Nemeth]

Thanks for your comments.  I'll update the README based on this
feedback.

Ruijie Yu <ruijie@netyu.xyz> writes:

> Didn't look into its sources, but the idea definitely sounds good.  Some
> in-line comments below regarding the commentary you attached.
>
> Felician Nemeth <felician.nemeth@gmail.com> writes:
>
>> I'd like to submit a new package called eglot-x to ELPA.  Its commentary
>> starts with:
>>
>> ;; Eglot supports (a subset of) the Language Server Protocol.  However,
>
> I think you should mention (as you did down below) that eglot only
> supports standardized protocol features of the LSP, in particular,
> _nothing more_ -- hence your package to support commonly-used, yet not
> standardized protocol specs.  Thoughts?
>
>> ;; there are useful protocol extensions that are not part of the
>> ;; official protocol specification.  Eglot-x adds support for some of
>> ;; them.  If you find a bug in Eglot, please, try to reproduce it
>
> New paragraph here at "if"?
>
>> ;; without Eglot-x, because Eglot-x is substantially modifies Eglot's
>
> Syntax: change "is substantially modifies" into either "substantially
> modifies" or "has substantially modified".
>
>> ;; normal behavior as well.
>>
>> João intend to support only the standardized protocol features in
>> eglot.el, but lots of LSP servers extend the protocol in their own way.
>> (It was João who suggested the package name long ago.)  I considered
>> eglot-x just an experiment and a learning possibility, but people seem
>> to use it, so I'd like to make their life easier by this submission.
>>
>> Currently, it mainly implements extensions for rust-analyzer and taplo,
>> but some other extensions are supported as well.
>>
>> The package is hosted at https://github.com/nemethf/eglot-x
>>
>> Thanks,
>> Felicián