Re: [Gnu-arch-users] Dirname caching for leroy's tla on cygwin

[John Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Well, I've been testing the path cache code, and I've found it doesn't
really work. The reason is that pathcompress_compress_path gets called
multiple times before it actually compresses a directory.

I added a bunch of logging and basically I found it does:

compress(...{arch}/cat/cat-b/cat-b-v/address@hidden/patch-log)
compress(...{arch}/cat/cat-b/cat-b-v/address@hidden)
compress(...{arch}/cat/cat-b/cat-b-v)
compress(...{arch}/cat/cat-b)
compress(...{arch}/cat)
compress(...{arch})
compress(...{arch}/cat)
compress(...{arch}/cat) <- first one that is actually compressed
compress(...{arch}/cat)
compress(...{arch}/cat)
compress(...{arch}/cat)

compress(...{arch}/cat/cat-b) -> {arch}/0/cat-b
compress(...{arch}/cat/cat-b) -> {arch}/0/cat-b ...
compress(...{arch}/cat/cat-b) -> {arch}/0/0
compress(...{arch}/cat/cat-b)
compress(...{arch}/cat/cat-b)

...

I can send a full logfile if you'd like to see more detail. Basically
there is some sort of recursive call to generate all the =dirnames
starting at a very long path. And until it actually finds a directory
(in this case "{arch}") pathcompress_process returns an uncompressed path.

So what I need to know is when do we have an authoritative answer about
a directory? Should we be caching somewhere other than
pathcompress_compress_path?

Perhaps we could be adding the results somewhere else, but checking to
see if we have a path here.

It might be better to put it in pathcompress_process_dirnames in the
switch at PROCESS_ADD_DIRNAME, that at least seems to be the first place
that it gets set to an actually compressed value.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFA6g80JdeBCYSNAAMRAoPIAJ4lUWjNGvNKpcQ6wXoj9KaEiOBx0ACfYkib
jBEszXVg7jBqqwTp9ib/D3c=
=OATb
-----END PGP SIGNATURE-----